MultiAddress Display update #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibault-martinez
previously approved these changes
Dec 19, 2023
Alex6323
reviewed
Dec 19, 2023
Alex6323
reviewed
Dec 19, 2023
|
|
||
| /// Hash the [`MultiAddress`] with BLAKE2b-256. | ||
| #[inline(always)] | ||
| pub fn hash(&self) -> [u8; 32] { |
There was a problem hiding this comment.
why pub? users gonna need to work with the hash of it?
There was a problem hiding this comment.
I asked myself the same but since it's public anyway through the display I think it's fair to have the method pub
There was a problem hiding this comment.
yea, figured it wouldnt hurt to have available
thibault-martinez
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Changes MultiAddress Display to show the hashed total of its addresses instead of the addresses themselves
Fixes #1587